Skip to content

Support client_trusts_lsp=true on ldk-node #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support client_trusts_lsp=true on ldk-node #687

wants to merge 1 commit into from
+383 −12

Conversation

@martinsaposnic
Copy link

@martinsaposnic martinsaposnic commented Oct 29, 2025 •
edited
Loading

implement changes introduced on lightningdevkit/rust-lightning#3838 for rust-lightning.

as discussed, client_trusts_lsp is a flag set at startup.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 29, 2025 •
edited
Loading

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@martinsaposnic martinsaposnic force-pushed the client-trusts-lsp-2 branch 2 times, most recently from 4927b73 to 27dc7b4 Compare October 29, 2025 19:09
@ldk-reviews-bot ldk-reviews-bot requested a review from tnull October 29, 2025 19:16
@toneloc
Copy link

toneloc commented Oct 29, 2025

With LDK Node including this PR, I got a compilation error and had to add these imports

use crate::lightning::util::errors::APIError;
use crate::bitcoin::Transaction;

It compiled after that, then I tried to do LSPS2 JIT onboarding, but it failed ("route not found" from the client side).

Note sure if that's an issue with this PR or me.

@martinsaposnic
Copy link
Author

martinsaposnic commented Oct 29, 2025

I’m sorry. This should have been a draft. I just cherry picked the commits from the old PR. I will make CI pass in the next few days

@martinsaposnic martinsaposnic marked this pull request as draft October 29, 2025 21:05
@tnull tnull removed their request for review October 30, 2025 12:01
@tnull
Copy link
Collaborator

tnull commented Oct 30, 2025

Alright, @martinsaposnic please ping me for review as soon as this is ready!

@toneloc
Copy link

toneloc commented Nov 11, 2025

Any progress here? Thanks @martinsaposnic

@tnull tnull added this to the 0.7 milestone Nov 13, 2025
@tnull tnull mentioned this pull request Nov 13, 2025
Open
10 tasks
@martinsaposnic martinsaposnic force-pushed the client-trusts-lsp-2 branch 4 times, most recently from bfeb9c0 to 7835f72 Compare November 13, 2025 14:16
@martinsaposnic
Support client_trusts_lsp=true on ldk-node
97d9e53 
implement changes introduced on lightningdevkit/rust-lightning#3838
as discussed, client_trusts_lsp is a flag set at startup.
a new function receive_via_jit_channel_manual_claim is introduced to bolt11 so we allow the client to
manually claim a payment (used on tests).
@martinsaposnic martinsaposnic marked this pull request as ready for review November 13, 2025 14:22
@martinsaposnic
Copy link
Author

martinsaposnic commented Nov 13, 2025

@tnull this should be ready now. let me know if you have comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull Awaiting requested review from tnull

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@martinsaposnic @ldk-reviews-bot @toneloc @tnull